DownloadCounter Moved Closer to CTA#412
Open
RounakJoshi09 wants to merge 1 commit intoadoptium:mainfrom
Open
Conversation
…ayout - Adjusted styles in DownloadCounter for improved responsiveness, including font sizes and padding.
✅ Deploy Preview for adoptium-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
Member
|
it's the same content that the #413 |
Contributor
Author
|
Hi @xavierfacq , Thanks for taking the time to review this. This PR #412 and PR #413 are nearly identical, with one key difference: in PR #413, the download count appears below the adopters carousel, while in this PR, it's positioned below the download button. Both placements were suggested in issues #397 , so I’ve submitted PRs for each approach. Feel free to merge whichever looks best and close the other accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#397
Another implementation of this enhancement is raised under DownloadCounter Moved Below Carousel #413
@CarmenDelgadoEclipse @gdams @smlambert Please check, if this PR aligns with your expectation. Happy to make adjustments if needed!
Description of change
screen-capture.1.webm
Checklist
npm testandnpm run buildpasses