Skip to content

DownloadCounter Moved Below Carousel#413

Open
RounakJoshi09 wants to merge 3 commits intoadoptium:mainfrom
RounakJoshi09:rounakj/download-section-below-crousel
Open

DownloadCounter Moved Below Carousel#413
RounakJoshi09 wants to merge 3 commits intoadoptium:mainfrom
RounakJoshi09:rounakj/download-section-below-crousel

Conversation

@RounakJoshi09
Copy link
Copy Markdown
Contributor

Description of change

These updates reposition the download counter beneath the carousel to enhance clarity and intuitiveness. By surfacing the number of existing downloads more prominently, users gain immediate credibility and reassurance, reinforcing trust in the product from the moment they engage. This is the other version of this PR #412

image

Checklist

  • npm test and npm run build passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

…ayout

- Adjusted styles in DownloadCounter for improved responsiveness, including font sizes and padding.
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 4, 2025

Deploy Preview for adoptium-next ready!

Name Link
🔨 Latest commit ffa724d
🔍 Latest deploy log https://app.netlify.com/projects/adoptium-next/deploys/68e10637ad2726000840e079
😎 Deploy Preview https://deploy-preview-413--adoptium-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xavierfacq
Copy link
Copy Markdown
Member

You need to update the test snapshot.

npm run update-snapshots

Question: there is another PR with same changes, is it normal?

@RounakJoshi09
Copy link
Copy Markdown
Contributor Author

HI @xavierfacq , Yes, there's another PR that takes a slightly different approach. Both suggestions were outlined in issue #397 , so I went ahead and raised both PRs. Feel free to merge whichever one seems more suitable and close the other accordingly.

@xavierfacq
Copy link
Copy Markdown
Member

Ok thanks for the clarification. Can you ask @CarmenDelgadoEclipse to choose which one is the best?

@CarmenDelgadoEclipse
Copy link
Copy Markdown
Contributor

Ok thanks for the clarification. Can you ask @CarmenDelgadoEclipse to choose which one is the best?

Thank you @xavierfacq yes, as you will find on the issue this is under marketing committee disucssion :) We will let you know.

@xavierfacq xavierfacq changed the title DownloadCounter Moved Below Crousel DownloadCounter Moved Below Carousel Nov 28, 2025
@tellison
Copy link
Copy Markdown
Contributor

tellison commented Dec 4, 2025

Thank you @xavierfacq yes, as you will find on the issue this is under marketing committee disucssion :) We will let you know.

@CarmenDelgadoEclipse any update for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants