winPB: Stop using ansible.windows as prefix to tasks

[sxa]

The Windows playbooks are not currently able to run using the setup process for running our windows docker containers as they fail with a ERROR! no action detected in task message when we try to run them using the ansible supplied with a default cygwin install. The implementatino of fully qualifications were done under:

• WindowsPB: Add Incredibuild Dashboard Configuration Task #3726
• WinPB: Add Installation of VS2022 Redists #3774

I've got a feeling there was a reason we did this but I'm not sure what it is and it's currently causing me a problem, so I'd like to remove the full qualification for now, unless there is another simple solution.

NOTE: Up til now we've been using a fixed version of the playbooks as specified in

infrastructure/ansible/docker/Dockerfile.win2022

Line 49 in e23e780

C:\cygwin64\bin\git clone https://github.com/sxa/infrastructure -b windows_docker_support c:/infrastructure & \

to create the containers. This branch (which has now been merged) did not have the above two PRs so hasn't been causing a problem. This error was found while attempting to bring that up to date so we can use the master branch going forward. Also noting that there is one other issue relating to the ant-contrib download being unreliable that will also need to be addressed - I've worked around that in another branch for now.

Checklist

• commit message has one of the standard prefixes
• faq.md updated if appropriate
• other documentation is changed or added (if applicable)
• playbook changes run through VPC or QPC (if you have access) https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/2014/
• VPC/QPC not applicable for this PR
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

[sxa]

Noting that the same error is showing up with the first task in the Incredibuild role with this change, so it will require a rethink.

[sxa]

Note: This was added as part of #3726 so we need to re-evaluate whether it's necessary.

[steelhead31]

I think the fully qualified names are to explicitly use the correct tasks. Since ansible 2.9 all the tasks are organised into collections, being explicit prevents any issues with namespaces. I think prefixing names, is considered best practice ( and maybe the linters complain? ) we could look to explicitly specify which collections are used with

collections:
    - ansible.windows

However this can only be done, after we move specifically our vagrant infrastructure to a later version of ansible. This collections tag can be specified at playbook level.