Skip to content

feat(judge): load an authenticated session for browser review (storage_state)#273

Merged
jacsamell merged 1 commit into
mainfrom
feat/judge-browser-storage-state
Jun 3, 2026
Merged

feat(judge): load an authenticated session for browser review (storage_state)#273
jacsamell merged 1 commit into
mainfrom
feat/judge-browser-storage-state

Conversation

@jacsamell
Copy link
Copy Markdown
Contributor

What

Browser-judges on auth-gated apps only ever reached the login redirect — an unauthenticated headless browser has no session. This adds opt-in verify.dev_server.storage_state: a Playwright storageState file (cookies + localStorage) the judge's @playwright/mcp loads via --storage-state, so it reviews the app logged-in.

Changes

  • DevServerConfig.storage_state + loader.
  • _augment_playwright_args injects --storage-state (idempotent; operator args win).
  • _populate_browser_context resolves the path (repo-root-relative or absolute) and fails closed: configured-but-missing → [BROWSER UNAVAILABLE] with an actionable reason (generate the session first) rather than wasting the pass on login pages. Unset → logged-out browsing as before (fine for public apps).

cube only consumes the file; generating it is out of band (reuse the app's e2e auth setup).

Tests

5 new (--storage-state inject / omit / idempotent). Automation + core suites green (499 passed).

🤖 Generated with Claude Code

…e_state)

Browser-judges on auth-gated apps only ever reached the login redirect — an
unauthenticated headless browser has no session. Add an opt-in
`verify.dev_server.storage_state` (repo-root-relative or absolute): a Playwright
storageState file (cookies + localStorage) that the judge's @playwright/mcp
loads via --storage-state, so it reviews the app logged-in.

- DevServerConfig.storage_state + loader.
- _augment_playwright_args injects --storage-state (idempotent; operator args win).
- _populate_browser_context resolves the path and fails closed: configured-but-
  missing → [BROWSER UNAVAILABLE] with an actionable reason (generate the
  session, e.g. an e2e auth-setup task), rather than wasting the pass on login
  pages. Unset → logged-out browsing as before (fine for public apps).

cube only consumes the file; generating it is out of band (reuse the e2e
suite's auth setup). 5 new tests; automation+core suites green (499 passed).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@jacsamell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 25 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57517754-1a62-459f-90a0-00f837503acc

📥 Commits

Reviewing files that changed from the base of the PR and between 835283f and ed955ab.

📒 Files selected for processing (4)
  • python/cube/automation/judge_panel.py
  • python/cube/core/dev_server.py
  • python/cube/core/user_config.py
  • tests/automation/test_judge_panel_browser_gating.py

Comment @coderabbitai help to get the list of available commands and usage tips.

@jacsamell jacsamell merged commit 4d56228 into main Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant