fix(judge): relocate browser screenshots into screenshots_dir#274
Conversation
…_dir @playwright/mcp writes browser_take_screenshot files relative to its cwd (the worktree run_dir), NOT --output-dir — only snapshots honour output-dir. So a judge's PNG landed in the worktree root while its decision file (and the posted review's '📸 Screenshots' block) referenced screenshots_dir/<name>.png, which then didn't resolve. run_judge now snapshots the pre-existing top-level PNGs and, after the stream, moves only the ones this run created into screenshots_dir — never touching committed assets. The posted screenshot paths now point at real files. Verified live: judge_4 logged into the app via the storage_state session, navigated /assistants, opened the Add Function Tool modal, and captured a real authenticated screenshot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 24 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
What
@playwright/mcpwritesbrowser_take_screenshotfiles relative to its cwd (the worktreerun_dir), not--output-dir(only snapshots honour output-dir). So a judge's PNG landed in the worktree root while its decision file — and the posted review's📸 Screenshotsblock — referencedscreenshots_dir/<name>.png, which didn't resolve.Fix
run_judgesnapshots the pre-existing top-level PNGs and, after the stream completes, moves only the ones this run created intoscreenshots_dir(never touching committed assets). Posted screenshot paths now point at real files.Verified live
judge_4 logged into the app via a
storage_statesession, navigated/assistants, opened the Add Function Tool modal, and captured a real authenticated screenshot — the last gap was the file landing in the worktree root instead ofscreenshots_dir.🤖 Generated with Claude Code