Skip to content

fix(judge): relocate browser screenshots into screenshots_dir#274

Merged
jacsamell merged 1 commit into
mainfrom
fix/judge-screenshots-land-in-dir
Jun 3, 2026
Merged

fix(judge): relocate browser screenshots into screenshots_dir#274
jacsamell merged 1 commit into
mainfrom
fix/judge-screenshots-land-in-dir

Conversation

@jacsamell
Copy link
Copy Markdown
Contributor

What

@playwright/mcp writes browser_take_screenshot files relative to its cwd (the worktree run_dir), not --output-dir (only snapshots honour output-dir). So a judge's PNG landed in the worktree root while its decision file — and the posted review's 📸 Screenshots block — referenced screenshots_dir/<name>.png, which didn't resolve.

Fix

run_judge snapshots the pre-existing top-level PNGs and, after the stream completes, moves only the ones this run created into screenshots_dir (never touching committed assets). Posted screenshot paths now point at real files.

Verified live

judge_4 logged into the app via a storage_state session, navigated /assistants, opened the Add Function Tool modal, and captured a real authenticated screenshot — the last gap was the file landing in the worktree root instead of screenshots_dir.

🤖 Generated with Claude Code

…_dir

@playwright/mcp writes browser_take_screenshot files relative to its cwd
(the worktree run_dir), NOT --output-dir — only snapshots honour output-dir.
So a judge's PNG landed in the worktree root while its decision file (and the
posted review's '📸 Screenshots' block) referenced screenshots_dir/<name>.png,
which then didn't resolve.

run_judge now snapshots the pre-existing top-level PNGs and, after the stream,
moves only the ones this run created into screenshots_dir — never touching
committed assets. The posted screenshot paths now point at real files.

Verified live: judge_4 logged into the app via the storage_state session,
navigated /assistants, opened the Add Function Tool modal, and captured a real
authenticated screenshot.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jacsamell jacsamell merged commit cf5a1f7 into main Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@jacsamell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 16 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9d3bd49-f5bc-4af4-a8b5-68903b751d0d

📥 Commits

Reviewing files that changed from the base of the PR and between 4d56228 and 9fa1314.

📒 Files selected for processing (1)
  • python/cube/automation/judge_panel.py

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant