Remove browserify, Use rollup#1561
Merged
ShinobuTakahashi merged 42 commits intomainfrom Mar 12, 2026
Merged
Conversation
Merged
Merged
Use memfs other
Use memfs for commons
ShinobuTakahashi
commented
Mar 3, 2026
| @@ -1,12 +1,17 @@ | |||
| import * as fs from "fs"; | |||
Contributor
Author
There was a problem hiding this comment.
browserify -> rollup 変更のファイルで、この PR でレビューしていただきたいファイルです。
CI で落ちていますが、#1703 で対応しています。
ShinobuTakahashi
changed the title
ShinobuTakahashi
commented
Mar 3, 2026
| @@ -0,0 +1,45 @@ | |||
| import * as fs from "fs"; | |||
Contributor
Author
There was a problem hiding this comment.
テスト関連のファイルは #1561, #1586 でレビュー済みです。
レビューしていただきたい、Rollup の変更関連 は NodeModules.ts です。
xnv
approved these changes
Mar 6, 2026
Comment on lines
+148
to
+149
| } catch (e) { | ||
| throw new Error(e); |
Member
There was a problem hiding this comment.
投げ直したいだけならこの catch 節は削除したいです。 new Error() の第一引数は文字列 (エラーメッセージ) のはずですが、 e が文字列であるとは限らない (というかほぼそうでない) でしょうし。
Contributor
Author
There was a problem hiding this comment.
ありがとうございます。修正しました。
Fix after merge in latest
kamakiri01
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
browserify をやめ、rollup を使用するようにします。
レビューしていただきたいRollup の変更関連 は NodeModules.ts です。
テスト関連のファイルは#1576, #1586 でレビュー済みです。
CI 落ちていますが、#1703 で修正しています。マージ後 CI 確認します。
動作確認
このブランチを使い
akashic initでコンテンツを作りserveまで機能を確認。