Fix after merge in latest#1703
Merged
ShinobuTakahashi merged 5 commits intoremove-browserify-use-rollupfrom Mar 9, 2026
Merged
Fix after merge in latest#1703ShinobuTakahashi merged 5 commits intoremove-browserify-use-rollupfrom
ShinobuTakahashi merged 5 commits intoremove-browserify-use-rollupfrom
Conversation
ShinobuTakahashi
commented
Mar 3, 2026
| "memfs": "4.23.0", | ||
| "mock-require": "^3.0.3", | ||
| "shx": "0.3.4", | ||
| "shx": "0.4.0", |
Contributor
Author
There was a problem hiding this comment.
package.json はインストール時に deprecated となるモジュールのバージョン更新や、不要となったモジュールを削除しています。
ShinobuTakahashi
commented
Mar 4, 2026
| "@akashic/remark-preset-lint": "^0.1.2", | ||
| "@changesets/changelog-github": "^0.5.0", | ||
| "@changesets/cli": "^2.27.5", | ||
| "@types/node": "^22.19.13", |
Contributor
Author
There was a problem hiding this comment.
下記、インストール時の警告で、changesets/cli 内で利用してる external-editor が @types/node の18以上を必要としていたので @types/node@22 を追加。
npm warn ERESOLVE overriding peer dependency
...
npm warn peerOptional @types/node@">=18" from @inquirer/external-editor@1.0.3
ShinobuTakahashi
commented
Mar 4, 2026
| node_modules/ | ||
| packages/akashic-cli-serve/www/public/thirdparty/ | ||
| CHANGELOG.md | ||
| .changeset/ |
Contributor
Author
There was a problem hiding this comment.
remark-cli を更新し changeset のファイルが lint で引っかかるようになったので ignore に追加
kamakiri01
approved these changes
Mar 4, 2026
xnv
approved these changes
Mar 6, 2026
ShinobuTakahashi
merged commit 97b9b55
into
remove-browserify-use-rollup
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
rollup 使用するブランチ(#1561) に main をマージ後の問題を修正
インストール時に deprecated となるモジュールを更新。
備考
#1561 へマージします