Fix quick sort#8
Open
FeschenkoNatalia wants to merge 1 commit into
Open
Conversation
pavlom0x
reviewed
Apr 9, 2018
| @@ -1,4 +1,3 @@ | |||
|
|
|||
| const should = require('should'); | |||
| const algo = require('../../index.js'); | |||
Member
There was a problem hiding this comment.
Can your algorithm sort numbers less than 0?
Member
There was a problem hiding this comment.
Cant you sort in descend order?
Member
Author
There was a problem hiding this comment.
According to your questions, my algorithm can sort numbers less than 0 and strings.
All necessary tests were added and passed.
But you are right it can't sort in the descend order.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Sorting function should take 2 arguments
- array of elements
- function comparator, to compare elements
Member
|
Same notes applicable to all sorting methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.