Skip to content

Fix quick sort #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FeschenkoNatalia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix quick sort #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/sorts/quick-sort/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

@pavlom0x pavlom0x Apr 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting function should take 2 arguments

  • array of elements
  • function comparator, to compare elements

module.exports = function quickSort(array) {
if (array.length === 0 || array.length < 2) {
return array;
Expand Down
1 change: 0 additions & 1 deletion lib/sorts/quick-sort/quick-sort.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

const should = require('should');
const algo = require('../../index.js');

@pavlom0x pavlom0x Apr 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your algorithm sort numbers less than 0?

@pavlom0x pavlom0x Apr 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sort strings?

@pavlom0x pavlom0x Apr 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant you sort in descend order?

@FeschenkoNatalia FeschenkoNatalia Apr 9, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your questions, my algorithm can sort numbers less than 0 and strings.
All necessary tests were added and passed.
But you are right it can't sort in the descend order.


Expand Down