style(sight): apply rustfmt + clippy -D warnings#668
Closed
jfeng18 wants to merge 3 commits into
Closed
Conversation
jfeng18
requested review from
casparant,
chengshuyi and
kongche-jbw
as code owners
github-actions
Bot
added
component:sight
jfeng18
force-pushed
the
chore/sight-ci-gate
branch
2 times, most recently
from
a6919b0 to
e071d19
Compare
jfeng18
force-pushed
the
chore/sight-ci-gate
branch
2 times, most recently
from
622cf90 to
f0781b2
Compare
This was referenced Jun 2, 2026
jfeng18
force-pushed
the
chore/sight-ci-gate
branch
2 times, most recently
from
92913a3 to
00f3707
Compare
2 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jfeng18
force-pushed
the
chore/sight-ci-gate
branch
from
00f3707 to
73b745f
Compare
jfeng18
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshed on latest main. Applies
cargo fmt+cargo clippy --fix+ manual fixes to make the agentsight crate fully rustfmt + clippy -D warnings clean.Changes
cargo fmton all 100+ source filescargo clippy --fixfor auto-fixable lints (format strings, vec init, etc.)strip_prefix,&Pathinstead of&PathBuf, doc indentation#[allow]for generated BPF skeleton lints (unnecessary_cast, missing_safety_doc, etc.)Not changed
Test plan
cargo clippy -- -D warnings= 0 errorscargo fmt --check= clean