Security: Arbitrary Code Execution via Dynamic Class Loading#164
Open
tomaioo wants to merge 1 commit into
Open
Security: Arbitrary Code Execution via Dynamic Class Loading#164tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The `get_class` helper function is used to dynamically load environment classes based on the `env_class` string attribute from `ExperimentConfig` (e.g., in `replay.py` and `eval_agent.py`). If an attacker can control the `env_class` configuration value, they can specify an arbitrary class path, leading to the instantiation and execution of arbitrary Python code. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Arbitrary Code Execution via Dynamic Class Loading
Problem
Severity:
Critical| File:src/holosoma/holosoma/replay.py:L22The
get_classhelper function is used to dynamically load environment classes based on theenv_classstring attribute fromExperimentConfig(e.g., inreplay.pyandeval_agent.py). If an attacker can control theenv_classconfiguration value, they can specify an arbitrary class path, leading to the instantiation and execution of arbitrary Python code.Solution
Restrict the
env_classconfiguration attribute to a predefined set of allowed environment classes. Validate the string against this allowlist before attempting to dynamically load and instantiate the class.Changes
src/holosoma/holosoma/replay.py(modified)