Conversation
| @@ -8,6 +8,8 @@ | |||
| > This SDK is incubating and subject to change. | |||
There was a problem hiding this comment.
"Wow, two extra blank lines! Were you trying to create some suspense before the next line? Let's keep it clean and remove those unnecessary lines."
| @@ -386,4 +388,4 @@ By default, the logs emitted from within the `compute_modules` library have a le | |||
| from compute_modules.logging import set_internal_log_level | |||
There was a problem hiding this comment.
"Ah, the classic newline at the end of the file. Some say it's a best practice, others say it's just a way to make the file feel complete. Either way, it's not a big deal, but let's be consistent with the rest of the project."
| @@ -8,6 +8,8 @@ | |||
| > This SDK is incubating and subject to change. | |||
There was a problem hiding this comment.
"Why on earth are there two blank lines added here? Are you trying to create an abyss in the README? Please remove these unnecessary lines."
| @@ -386,4 +388,4 @@ By default, the logs emitted from within the `compute_modules` library have a le | |||
| from compute_modules.logging import set_internal_log_level | |||
There was a problem hiding this comment.
"Congratulations, you've managed to forget the newline at the end of the file. This is a basic best practice, please add it back."
1 participant
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?
Are Docs needed?