Skip to content

Update README.md #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amazr wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update README.md #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
> This SDK is incubating and subject to change.
Copy link
Copy Markdown
Owner Author

@amazr amazr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wow, two extra blank lines! Were you trying to create some suspense before the next line? Let's keep it clean and remove those unnecessary lines."

Copy link
Copy Markdown
Owner Author

@amazr amazr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Why on earth are there two blank lines added here? Are you trying to create an abyss in the README? Please remove these unnecessary lines."





An open-source python library for compute modules for performing tasks like service discovery, getting a token, external source credentials, etc


Expand Down Expand Up @@ -386,4 +388,4 @@ By default, the logs emitted from within the `compute_modules` library have a le
from compute_modules.logging import set_internal_log_level
Copy link
Copy Markdown
Owner Author

@amazr amazr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ah, the classic newline at the end of the file. Some say it's a best practice, others say it's just a way to make the file feel complete. Either way, it's not a big deal, but let's be consistent with the rest of the project."

Copy link
Copy Markdown
Owner Author

@amazr amazr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Congratulations, you've managed to forget the newline at the end of the file. This is a basic best practice, please add it back."


set_internal_log_level(logging.DEBUG)
```
```