fix(frontend): restore verification commands#419
Open
anirudh5harma wants to merge 1 commit into
Open
Conversation
anirudh5harma
force-pushed
the
codex/fix-frontend-verification
branch
from
03ca46e to
959ecb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #418.
Frontend verification works again on clean checkouts:
npm run typecheckno longer fails on the Forge notarization config, andnpm run buildnow exists as the documented package-build command.The frontend workflow now runs typecheck before vitest, restoring the TypeScript guard that was previously disabled because of the pre-existing config error.
Tests
cd frontend && npm run typecheckcd frontend && npm run buildcd frontend && npm test -- --rungit diff --check