Skip to content

fix(frontend): restore verification commands #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anirudh5harma wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(frontend): restore verification commands #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ name: Frontend
# vitest.config.ts, and the repo had neither until #171) — this job is the
# guard against that happening again.
#
# Typecheck is intentionally NOT run here yet: forge.config.ts and
# update-electron-app carry pre-existing type errors. Add `npm run typecheck`
# once those are fixed.

on:
push:
branches: [main]
Expand Down Expand Up @@ -37,5 +33,8 @@ jobs:

- run: npm ci

- name: Typecheck
run: npm run typecheck

- name: Run vitest suite
run: npx vitest run
4 changes: 2 additions & 2 deletions frontend/forge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ForgeConfig } from "@electron-forge/shared-types";
import { VitePlugin } from "@electron-forge/plugin-vite";
import type { NotaryToolCredentials } from "@electron/notarize/lib/types";
import MakerNSIS from "./makers/maker-nsis";

const config: ForgeConfig = {
Expand Down Expand Up @@ -28,9 +29,8 @@ const config: ForgeConfig = {
: undefined,
osxNotarize: process.env.AO_NOTARY_PROFILE
? ({
tool: "notarytool",
keychainProfile: process.env.AO_NOTARY_PROFILE,
} as unknown as ForgeConfig["packagerConfig"]["osxNotarize"])
} satisfies NotaryToolCredentials)
: process.env.APPLE_ID
? {
appleId: process.env.APPLE_ID,
Expand Down
1 change: 1 addition & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
},
"scripts": {
"build:daemon": "node ./scripts/build-daemon.mjs",
"build": "npm run build:daemon && electron-forge package",
"dev": "electron-forge start",
"dev:web": "VITE_NO_ELECTRON=1 vite --config vite.renderer.config.ts",
"prepackage": "npm run build:daemon",
Expand Down