Dead tables always render on tserver monitor page#6397
Open
ArbaazKhan1 wants to merge 1 commit into
Open
Conversation
dlmarion
reviewed
May 28, 2026
| } | ||
| else { | ||
| $('#deadtservers_wrapper').show(); | ||
| } |
| ] | ||
| ], | ||
|
|
||
| // Only show the table if there are non-empty rows |
Contributor
There was a problem hiding this comment.
This comment suggests that maybe we should never hide the table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #6379
Added a
drawCallbackfunction to the Dead Tablet Servers DataTable initialization so that the table's visibility is explicitly toggled based on whether it has rows to display.