Skip to content

Dead tables always render on tserver monitor page #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArbaazKhan1 wants to merge 1 commit into
base: 2.1
Choose a base branch
from
+11 −7
Open

Dead tables always render on tserver monitor page #6397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/tservers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ function refreshTServersTable() {
function refreshDeadTServersTable() {
ajaxReloadTable(deadTServersTable);

// Only show the table if there are non-empty rows
if ($('#deadtservers tbody .dataTables_empty').length) {
$('#deadtservers_wrapper').hide();
} else {
$('#deadtservers_wrapper').show();
}
}

/**
Expand Down Expand Up @@ -312,7 +306,17 @@ $(document).ready(function () {
return data;
}
}
]
],

// Only show the table if there are non-empty rows
Copy link
Copy Markdown
Contributor

@dlmarion dlmarion May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment suggests that maybe we should never hide the table.

"drawCallback": function () {
if (this.api().rows().data().length === 0) {
$('#deadtservers_wrapper').hide();
}
else {
$('#deadtservers_wrapper').show();
}
Copy link
Copy Markdown
Contributor

@dlmarion dlmarion May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing seems off here

}
});

// Create a table for badServers list
Expand Down