fix!: Ensure ArrowTypeString never returns NULL#885
Open
paleolimbot wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
==========================================
- Coverage 79.96% 78.59% -1.38%
==========================================
Files 105 106 +1
Lines 15461 16119 +658
Branches 1738 1858 +120
==========================================
+ Hits 12364 12669 +305
- Misses 1998 2283 +285
- Partials 1099 1167 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lidavidm
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously an unknown type identifier would have resulted in a NULL; now a conspicuous-looking possibly helpful string is shown.
Almost all internal usage of ArrowTypeString is use in Printf strings, for which gcc now displays a warning if the value could be NULL.
This is a breaking change if anybody was relying on the null output here to detect an invalid type identifier.
Closes #884.