Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/src/nanoarrow/_array.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ cdef class CArrayView:
@property
def storage_type(self):
cdef const char* type_str = ArrowTypeString(self._ptr.storage_type)
if type_str != NULL:
return type_str.decode('UTF-8')
return type_str.decode('UTF-8')

@property
def layout(self):
Expand Down
10 changes: 2 additions & 8 deletions python/src/nanoarrow/_schema.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -594,18 +594,12 @@ cdef class CSchemaView:
@property
def type(self) -> str:
cdef const char* type_str = ArrowTypeString(self._schema_view.type)
if type_str != NULL:
return type_str.decode()
else:
raise ValueError("ArrowTypeString() returned NULL")
return type_str.decode()

@property
def storage_type(self) -> str:
cdef const char* type_str = ArrowTypeString(self._schema_view.storage_type)
if type_str != NULL:
return type_str.decode()
else:
raise ValueError("ArrowTypeString() returned NULL")
return type_str.decode()

@property
def dictionary_ordered(self) -> Union[bool, None]:
Expand Down
4 changes: 2 additions & 2 deletions src/nanoarrow/common/inline_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ enum ArrowType {
/// \brief Get a string value of an enum ArrowType value
/// \ingroup nanoarrow-utils
///
/// Returns NULL for invalid values for type
/// Returns "<unknown type identifier>" for invalid values for type
static inline const char* ArrowTypeString(enum ArrowType type);

static inline const char* ArrowTypeString(enum ArrowType type) {
Expand Down Expand Up @@ -569,7 +569,7 @@ static inline const char* ArrowTypeString(enum ArrowType type) {
case NANOARROW_TYPE_LARGE_LIST_VIEW:
return "large_list_view";
default:
return NULL;
return "<unknown type identifier>";
}
}

Expand Down
Loading