GH-50098: [C++][Parquet] Enable filesystem support when building Parquet utilities#50099
Merged
Merged
Conversation
…g Parquet utilities
pitrou
commented
Jun 4, 2026
| set_option_category("Parquet") | ||
|
|
||
| define_option(PARQUET_BUILD_EXECUTABLES | ||
| "Build the Parquet executable CLI tools. Requires static libraries to be built." |
Member
Author
There was a problem hiding this comment.
I've checked that static libraries are not required for the Parquet executables to work, so removing the misleading statement.
pitrou
marked this pull request as ready for review
June 4, 2026 13:34
github-actions
Bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2315161. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 84 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some Parquet utilities call the Arrow filesystem API.
Also make sure that compute benchmarks are not built when the full compute kernels registry is not enabled.
Are these changes tested?
Manually.
Are there any user-facing changes?
No.