Skip to content

GH-50222: [C++] Use FetchContent for xsimd #50303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 2 commits into from
Jul 6, 2026
Merged

GH-50222: [C++] Use FetchContent for xsimd #50303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a730140
Use fetchcontent for xsimd
AntoinePrv Jun 30, 2026
2027caf
Handle cmake<3.28
AntoinePrv Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 24 additions & 16 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2822,28 +2822,36 @@ if(ARROW_WITH_RAPIDJSON)
FALSE)
endif()

macro(build_xsimd)
function(build_xsimd)
list(APPEND CMAKE_MESSAGE_INDENT "xsimd: ")
message(STATUS "Building xsimd from source")
set(XSIMD_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/xsimd_ep/src/xsimd_ep-install")
set(XSIMD_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=${XSIMD_PREFIX}")

externalproject_add(xsimd_ep
${EP_COMMON_OPTIONS}
PREFIX "${CMAKE_BINARY_DIR}"
URL ${XSIMD_SOURCE_URL}
URL_HASH "SHA256=${ARROW_XSIMD_BUILD_SHA256_CHECKSUM}"
CMAKE_ARGS ${XSIMD_CMAKE_ARGS})
prepare_fetchcontent()
fetchcontent_declare(xsimd
${FC_DECLARE_COMMON_OPTIONS} OVERRIDE_FIND_PACKAGE
URL ${XSIMD_SOURCE_URL}
URL_HASH "SHA256=${ARROW_XSIMD_BUILD_SHA256_CHECKSUM}")
fetchcontent_makeavailable(xsimd)

set(XSIMD_INCLUDE_DIR "${XSIMD_PREFIX}/include")
# The include directory must exist before it is referenced by a target.
file(MAKE_DIRECTORY "${XSIMD_INCLUDE_DIR}")
if(CMAKE_VERSION VERSION_LESS 3.28)
set_property(DIRECTORY ${xsimd_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL TRUE)
endif()

set(xsimd_INCLUDE_DIR "${xsimd_SOURCE_DIR}/include")
add_library(arrow::xsimd INTERFACE IMPORTED)
target_include_directories(arrow::xsimd INTERFACE "${XSIMD_INCLUDE_DIR}")
add_dependencies(arrow::xsimd xsimd_ep)
target_include_directories(arrow::xsimd INTERFACE "${xsimd_INCLUDE_DIR}")

set(XSIMD_VENDORED TRUE)
endmacro()
set(XSIMD_VENDORED
TRUE
PARENT_SCOPE)
set(xsimd_INCLUDE_DIR
"${xsimd_INCLUDE_DIR}"
PARENT_SCOPE)
set(xsimd_FOUND
TRUE
PARENT_SCOPE)
list(POP_BACK CMAKE_MESSAGE_INDENT)
endfunction()

# Xsimd is mandatory as its CPU feature detection is the basis for Arrow CpuInfo
resolve_dependency(xsimd
Expand Down
Loading