fix(.asf.yaml): discussions notification target + real check names in branch protection#3404
Open
deacon-mp wants to merge 1 commit into
Open
fix(.asf.yaml): discussions notification target + real check names in branch protection#3404deacon-mp wants to merge 1 commit into
deacon-mp wants to merge 1 commit into
Conversation
…ames in branch protection ASF Infra rejects the github feature block with 'GitHub discussions can only be enabled if a mailing list target exists for it' — features.discussions requires a notifications.discussions target. Route it to dev@, alongside issues and pullrequests. Because that error aborted the whole github block, protected_branches has never actually applied. Its required_status_checks contexts named workflows (Code Quality, Security Checks) rather than check runs, which would never be reported and would wedge every merge once active. Replace them with the six real job names as recorded on GitHub check runs. Review requirement (1 approving review, stale-review dismissal) and strict up-to-date checks now take effect deliberately.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Apache Infra self-service configuration (.asf.yaml) to (1) satisfy ASF’s requirement for enabling GitHub Discussions and (2) correctly enforce branch protection on master using real GitHub Actions check-run (job) names so merges aren’t inadvertently blocked.
Changes:
- Add a
notifications.discussionsemail target required forgithub.features.discussions: true. - Replace branch protection required-status-check contexts from workflow names to the concrete job/check-run names emitted by GitHub Actions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
54
to
56
| protected_branches: | ||
| master: | ||
| required_pull_request_reviews: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the ASF Infra processing error emitted since #3400 merged:
Changes
notifications.discussions: dev@caldera.apache.org— per the asf.yaml spec,github.features.discussions: truerequires a discussions notification target. Routed to dev@ alongside issues and pullrequests traffic.protected_branchescontexts corrected to real check-run names. The previous contexts named workflows (Code Quality,Security Checks); GitHub required status checks match check-run (job) names, so those contexts would never be reported and — combined withstrict: true— would have wedged every merge the moment the block applied. Replaced with the six job names, verified byte-exact against the check runs recorded on master's head commit (46af343a): the fourbuild (3.x, ...coverage-ci)legs plusbuild (3.13, safety)andbuild (3.13, bandit).sonar_fork_pris deliberately excluded (only materializes on fork PRs).Effect when this lands
The discussions error has been aborting the entire
github:block, so none of it is currently applied. Once this merges and Infra processes it, the full block takes effect, including branch protection on master: 1 approving review required (stale reviews dismissed), the six CI contexts required, branches must be up to date, conversations must be resolved. This is a deliberate policy activation — from then on, PRs (including Dependabot's, whose six required contexts all still report) need a review before merge.