Skip to content

fix(.asf.yaml): discussions notification target + real check names in branch protection #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deacon-mp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(.asf.yaml): discussions notification target + real check names in branch protection #3404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ notifications:
commits: commits@caldera.apache.org
issues: dev@caldera.apache.org
pullrequests: dev@caldera.apache.org
discussions: dev@caldera.apache.org # required for github.features.discussions to be enabled
# jobs: dev@caldera.apache.org # GitHub Actions build status — enable if the project wants CI failures on-list
# jira_options: link label comment # only if Caldera adopts ASF Jira; it uses GitHub Issues, so omitted

Expand Down Expand Up @@ -49,17 +50,22 @@ github:
dependabot_alerts: true
dependabot_updates: false

# --- OPTIONAL self-serve branch protection (enable once the project agrees on required checks) ----
# --- Branch protection: 1 approving review + green CI required to merge to master -----------------
protected_branches:
master:
required_pull_request_reviews:
Comment on lines 54 to 56
required_approving_review_count: 1
dismiss_stale_reviews: true
required_status_checks:
strict: true
# Contexts must be check-run (job) names as reported to GitHub, not workflow names.
contexts:
- Code Quality
- Security Checks
- "build (3.10.9, py310,style,coverage-ci)"
- "build (3.11, py311,style,coverage-ci)"
- "build (3.12, py312,style,coverage-ci)"
- "build (3.13, py313,style,coverage-ci)"
- "build (3.13, safety)"
- "build (3.13, bandit)"
required_conversation_resolution: true
# # required_signatures: true # only if all committers sign commits — can block merges otherwise
copilot_code_review:
Expand Down
Loading