Fix typo in ISO url#2775
Merged
Merged
Conversation
Contributor
Author
|
@rhtyd @rafaelweingartner fixed typo. |
DaanHoogland
approved these changes
Jul 26, 2018
| "net_device": "virtio-net", | ||
|
|
||
| "iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1808.iso", | ||
| "iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso", |
Member
There was a problem hiding this comment.
Is this hash correct?
I took the hash of that file and it is something else:
$ wget http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso
$ md5sum CentOS-7-x86_64-Minimal-1804.iso
fabdc67ff3a1674a489953effa285dfd CentOS-7-x86_64-Minimal-1804.iso
Contributor
Author
There was a problem hiding this comment.
Actually I was just about to send the exact comment. The official repo has only sha1 and sha256 hashes (which is used in systemvmtemplate/template.json) but here the iso_checksum_type is set to md5. Either of those needs to be changed.
Member
There was a problem hiding this comment.
if the type can be set to sha1 or sha256, please do so. Otherwise, we need to configure the right hash value there.
12 tasks
Contributor
Author
|
I updated the checksum type to |
rafaelweingartner
approved these changes
Jul 26, 2018
yadvr
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The correct ISO url is http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso and not ends with
1808.Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Checklist:
Testing