Skip to content

Fix typo in ISO url#2775

Merged
yadvr merged 1 commit into
apache:4.11from
khos2ow:fix-typo
Jul 31, 2018
Merged

Fix typo in ISO url#2775
yadvr merged 1 commit into
apache:4.11from
khos2ow:fix-typo

Conversation

@khos2ow
Copy link
Copy Markdown
Contributor

@khos2ow khos2ow commented Jul 26, 2018

Description

The correct ISO url is http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso and not ends with 1808.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@khos2ow khos2ow changed the base branch from master to 4.11 July 26, 2018 14:51
@khos2ow
Copy link
Copy Markdown
Contributor Author

khos2ow commented Jul 26, 2018

@rhtyd @rafaelweingartner fixed typo.

"net_device": "virtio-net",

"iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1808.iso",
"iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this hash correct?

I took the hash of that file and it is something else:

$ wget http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso
$ md5sum CentOS-7-x86_64-Minimal-1804.iso
fabdc67ff3a1674a489953effa285dfd  CentOS-7-x86_64-Minimal-1804.iso

Copy link
Copy Markdown
Contributor Author

@khos2ow khos2ow Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was just about to send the exact comment. The official repo has only sha1 and sha256 hashes (which is used in systemvmtemplate/template.json) but here the iso_checksum_type is set to md5. Either of those needs to be changed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the type can be set to sha1 or sha256, please do so. Otherwise, we need to configure the right hash value there.

@khos2ow
Copy link
Copy Markdown
Contributor Author

khos2ow commented Jul 26, 2018

I updated the checksum type to sha1 and double checked that the has is actually valid, as well as the URL.

Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.11.2.0 milestone Jul 31, 2018
@yadvr yadvr merged commit 2be51ac into apache:4.11 Jul 31, 2018
@khos2ow khos2ow deleted the fix-typo branch July 31, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants