Skip to content

Fix typo in ISO url #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 1 commit into from
Jul 31, 2018
Merged

Fix typo in ISO url #2775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/appliance/builtin/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"disk_interface": "virtio",
"net_device": "virtio-net",

"iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1808.iso",
"iso_url": "http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso",
Copy link
Copy Markdown
Member

@rafaelweingartner rafaelweingartner Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this hash correct?

I took the hash of that file and it is something else:

$ wget http://mirror.nbrc.ac.in/centos/7/isos/x86_64/CentOS-7-x86_64-Minimal-1804.iso
$ md5sum CentOS-7-x86_64-Minimal-1804.iso
fabdc67ff3a1674a489953effa285dfd  CentOS-7-x86_64-Minimal-1804.iso

Copy link
Copy Markdown
Contributor Author

@khos2ow khos2ow Jul 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I was just about to send the exact comment. The official repo has only sha1 and sha256 hashes (which is used in systemvmtemplate/template.json) but here the iso_checksum_type is set to md5. Either of those needs to be changed.

Copy link
Copy Markdown
Member

@rafaelweingartner rafaelweingartner Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the type can be set to sha1 or sha256, please do so. Otherwise, we need to configure the right hash value there.

"iso_checksum": "13675c6f74880e7ff3481b91bdaf925ce81bda8f",
"iso_checksum_type": "md5",
"iso_checksum_type": "sha1",

"vm_name": "builtin",
"output_directory": "../dist",
Expand Down