Skip to content

KVM Volumes: Limit migration of volumes within the same storage pool.#3424

Merged
yadvr merged 5 commits into
apache:masterfrom
kioie:kioie/Limit-volume-migration-to-same-pool
Jun 27, 2019
Merged

KVM Volumes: Limit migration of volumes within the same storage pool.#3424
yadvr merged 5 commits into
apache:masterfrom
kioie:kioie/Limit-volume-migration-to-same-pool

Conversation

@kioie
Copy link
Copy Markdown
Contributor

@kioie kioie commented Jun 26, 2019

Description

Fixes #3291

ENVIRONMENT
KVM on CentOS7

SUMMARY
Added an if statement that catches the destination poolid as an invalid parameter if it is similer to the current poolid

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@yadvr yadvr added this to the 4.13.0.0 milestone Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@apache apache deleted a comment from blueorangutan Jun 26, 2019
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 26, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-38

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 26, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 26, 2019

Can you review @nvazquez @anuragaw @shwstppr

Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-34)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34967 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3424-t34-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit f9998e4 into apache:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KVM Volume: When detached, user is able to migrate the volume to the same storage

6 participants