Skip to content

KVM Volumes: Limit migration of volumes within the same storage pool. #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 5 commits into from
Jun 27, 2019
Merged

KVM Volumes: Limit migration of volumes within the same storage pool. #3424

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0463e9a
KVM Volumes: Limit migration of volumes within the same storage pool.
Jun 26, 2019
9f461d3
fix checkstyle issues and refactor
yadvr Jun 26, 2019
85bc5ed
fix space around + operator
yadvr Jun 26, 2019
0c8fa71
Update VolumeApiServiceImpl.java
yadvr Jun 26, 2019
c3531d2
Update VolumeApiServiceImpl.java
yadvr Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2033,6 +2033,10 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
throw new InvalidParameterValueException("Volume must be in ready state");
}

if (vol.getPoolId() == storagePoolId) {
throw new InvalidParameterValueException("Volume " + vol + " is already on the destination storage pool");
}

boolean liveMigrateVolume = false;
Long instanceId = vol.getInstanceId();
Long srcClusterId = null;
Expand Down Expand Up @@ -3384,4 +3388,4 @@ public String getConfigComponentName() {
public ConfigKey<?>[] getConfigKeys() {
return new ConfigKey<?>[] {ConcurrentMigrationsThresholdPerDatastore};
}
}
}