Bug fix for distinting between string and map type tags in forms#3441
Merged
Conversation
Some APIs consume 'tags' param as string and some consume as maps. Since each API can have at most one 'tags' param the extraction of map based tags should only happen when strings based tags are not extracted from the form serialization.
Contributor
Author
|
ping for review - @rhtyd , @shwstppr , @nvazquez , @borisstoyanov , @PaulAngus |
yadvr
approved these changes
Jun 28, 2019
Member
yadvr
left a comment
There was a problem hiding this comment.
lgtm, however, it's affects all users of the change and without testing it's hard to tell if it will cause any regressions
Contributor
Author
|
Tags extraction was a recent change I had worked on for supporting snapshot and snapshot policy tags. This was merged in the last few days . This PR change makes it more conservative and avoids overwriting of string based tags if any because a form should not contain multiple params with name 'tags' |
shwstppr
approved these changes
Jun 28, 2019
Member
|
Merged based on reviews, manual test and screenshot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Some APIs consume 'tags' param as string and some consume as maps.
Since each API can have at most one 'tags' param the extraction of
map based tags should only happen when strings based tags are not
extracted from the form serialization.
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Try tagging in 2 different places -
Both places should work. Without this patch only former would work.