Skip to content

Bug fix for distinting between string and map type tags in forms #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 2 commits into from
Jun 28, 2019
Merged

Bug fix for distinting between string and map type tags in forms #3441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc86e34
Bug fix for distinting between string and map type tags in forms
Jun 28, 2019
1b713d4
Fix typo
Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ui/scripts/ui/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,14 @@

var complete = function($formContainer) {
var $form = $formContainer.find('form');
var data = $.extend(cloudStack.serializeForm($form), {'tags' : cloudStack.getTagsFromForm($form)});
var data = cloudStack.serializeForm($form);
if (!data.tags) {
// Some APIs consume tags as a string (such as disk offering creation).
// The UI of those use a tagger that is not a custom cloudStack.tagger
// but rather a string. That case is handled by usual serialization. We
// only need to check extract tags when the string tags are not present.
$.extend(data, {'tags' : cloudStack.getTagsFromForm($form)});
}

if (!$formContainer.find('form').valid()) {
// Ignore hidden field validation
Expand Down