Skip to content

[vmware, ssvm] Scale down of ssvm#6042

Merged
sureshanaparti merged 2 commits into
apache:4.16from
shapeblue:fix-ssvm-option-2
Feb 25, 2022
Merged

[vmware, ssvm] Scale down of ssvm#6042
sureshanaparti merged 2 commits into
apache:4.16from
shapeblue:fix-ssvm-option-2

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Feb 24, 2022 •
edited
Loading

Description

This PR addresses the SSVM scaling issue noticed on VMware.
When active cmds i.e., no of entries in cmd_exec_log table is 0 and the SSVM standby capacity - secstorage.capacity.standby is higher than the max sessions an SSVM can handle secstorage.session.max, then the no of SSVMs get scaled up. However, when there aren't any active commands, a logic is added to scale down the SSVMs.

Fixes: #6038

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594 Pearl1594 added this to the 4.16.1.0 milestone Feb 24, 2022
nvazquez
nvazquez approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

weizhouapache
weizhouapache approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Pearl1594 Pearl1594 linked an issue Feb 24, 2022 that may be closed by this pull request
SSVM scaling issue #6038
Closed
sureshanaparti
sureshanaparti reviewed Feb 24, 2022
View reviewed changes
Comment thread engine/components-api/src/main/java/com/cloud/storage/StorageManager.java Outdated
@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Feb 24, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2022

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2708

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Feb 24, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2022

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Feb 24, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2709

@nvazquez
Copy link
Copy Markdown
Contributor

nvazquez commented Feb 24, 2022

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 24, 2022

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 25, 2022

Trillian test result (tid-3432)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35363 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6042-t3432-vmware-67u3.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually checked the scale down mechanism works fine. This should keep the systemvms up until destroyed explicitly

@sureshanaparti sureshanaparti merged commit a8cc261 into apache:4.16 Feb 25, 2022
@sureshanaparti sureshanaparti mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@borisstoyanov borisstoyanov

Labels

component:ssvm Severity:Critical Critical bug type:bug

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

SSVM scaling issue

8 participants

@Pearl1594 @borisstoyanov @blueorangutan @sureshanaparti @nvazquez @yadvr @weizhouapache @DaanHoogland