Skip to content

revert cleanup of test_acl_sharenetworks#7033

Merged
DaanHoogland merged 2 commits intoapache:mainfrom
shapeblue:testAclShNt-revert
Dec 31, 2022
Merged

revert cleanup of test_acl_sharenetworks#7033
DaanHoogland merged 2 commits intoapache:mainfrom
shapeblue:testAclShNt-revert

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

Description

This PR reverts changes that broke the gh action for test_acl_sharednetworks.py

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Comment thread test/integration/component/test_acl_sharednetwork.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.53%. Comparing base (4d41b6b) to head (29818d9).
⚠️ Report is 3265 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7033       +/-   ##
=============================================
+ Coverage      6.56%   11.53%    +4.97%     
+ Complexity     8441     7517      -924     
=============================================
  Files          4361     2494     -1867     
  Lines        370925   246787   -124138     
  Branches      47614    38533     -9081     
=============================================
+ Hits          24360    28476     +4116     
+ Misses       343630   214631   -128999     
- Partials       2935     3680      +745     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Dec 30, 2022
@DaanHoogland DaanHoogland marked this pull request as ready for review December 30, 2022 11:42
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland DaanHoogland merged commit 73a610d into apache:main Dec 31, 2022
@DaanHoogland DaanHoogland deleted the testAclShNt-revert branch January 10, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants