Skip to content

api,server,ui: add project ID and name to UserDataResponse#8656

Merged
sureshanaparti merged 2 commits intoapache:4.19from
weizhouapache:4.19-add-project-id-name-to-userdata
Mar 25, 2024
Merged

api,server,ui: add project ID and name to UserDataResponse#8656
sureshanaparti merged 2 commits intoapache:4.19from
weizhouapache:4.19-add-project-id-name-to-userdata

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes #8363

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

image

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bda49ab) 30.90% compared to head (fb54df0) 30.90%.
Report is 2 commits behind head on 4.19.

Files Patch % Lines
...ache/cloudstack/api/response/UserDataResponse.java 0.00% 4 Missing ⚠️
ui/src/config/section/compute.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8656      +/-   ##
============================================
- Coverage     30.90%   30.90%   -0.01%     
+ Complexity    34189    34187       -2     
============================================
  Files          5347     5347              
  Lines        375566   375570       +4     
  Branches      54625    54626       +1     
============================================
- Hits         116068   116056      -12     
- Misses       244236   244250      +14     
- Partials      15262    15264       +2     
Flag Coverage Δ
simulator-marvin-tests 24.75% <20.00%> (-0.01%) ⬇️
uitests 4.39% <20.00%> (-0.01%) ⬇️
unit-tests 16.55% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8664

Comment thread api/src/main/java/org/apache/cloudstack/api/response/UserDataResponse.java Outdated
@DaanHoogland
Copy link
Copy Markdown
Contributor

@weizhouapache , given the name of your branch is this for 4.19?

@weizhouapache
Copy link
Copy Markdown
Member Author

@weizhouapache , given the name of your branch is this for 4.19?

@DaanHoogland
the branch is based on 4.19.
However, I added to 4.20.0.0 milestone as I am not sure if it is a bug fix. If it is, we can change the target branch to 4.19

@DaanHoogland
Copy link
Copy Markdown
Contributor

I think a backwards compatible enhancement like this can go into a minor release.

@weizhouapache weizhouapache changed the base branch from main to 4.19 February 15, 2024 13:01
@weizhouapache
Copy link
Copy Markdown
Member Author

I think a backwards compatible enhancement like this can go into a minor release.

OK @DaanHoogland
changed the target branch to 4.19
I will add since in response.

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@yadvr yadvr modified the milestones: 20.0.0, 4.19.1.0 Feb 16, 2024
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 16, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8678

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 8, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9430)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46848 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8656-t9430-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_07_arping_in_vr Failure 5.18 test_diagnostics.py

@DaanHoogland
Copy link
Copy Markdown
Contributor

@sureshanaparti , I think we can merge at your will.

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti sureshanaparti merged commit 08d9d06 into apache:4.19 Mar 25, 2024
@DaanHoogland DaanHoogland deleted the 4.19-add-project-id-name-to-userdata branch March 28, 2024 07:28
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Apr 9, 2024
* api,server,ui: add project ID and name to UserDataResponse

* Update: add since
@weizhouapache weizhouapache mentioned this pull request Jul 11, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add project information to UserData Response

5 participants