UI: Fix error message in zone wizard#8721
Merged
yadvr merged 1 commit intoapache:4.18from Feb 28, 2024
Merged
Conversation
DaanHoogland
approved these changes
Feb 28, 2024
| "message.request.failed": "Request failed.", | ||
| "message.required.add.least.ip": "Please add at least 1 IP Range", | ||
| "message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each network should have a label.", | ||
| "message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each traffic type should have a label.", |
Contributor
There was a problem hiding this comment.
lgtm, but @andrijapanicsb , is this really what the message should say?
Contributor
There was a problem hiding this comment.
If we stick to the grammar wording (should (don't have to) vs. must (have to)) - then yes. The problem was that it said each network should have a label, while actually, traffic types are having labels (not networks) - that is why this change is there @DaanHoogland
See this comment (where this comes from #8625 (comment) )
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8721 +/- ##
============================================
- Coverage 13.16% 13.16% -0.01%
Complexity 9203 9203
============================================
Files 2724 2724
Lines 258130 258137 +7
Branches 40232 40235 +3
============================================
Hits 33989 33989
- Misses 219833 219840 +7
Partials 4308 4308 ☔ View full report in Codecov by Sentry. |
yadvr
approved these changes
Feb 28, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the error message in zone wizard as mentioned here: #8625 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?