Skip to content

UI: Fix error message in zone wizard #8721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yadvr merged 1 commit into from
Feb 28, 2024
Merged

UI: Fix error message in zone wizard #8721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2845,7 +2845,7 @@
"message.remove.vpc": "Please confirm that you want to remove the VPC",
"message.request.failed": "Request failed.",
"message.required.add.least.ip": "Please add at least 1 IP Range",
"message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each network should have a label.",
"message.required.traffic.type": "All required traffic types should be added and with multiple physical networks each traffic type should have a label.",
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but @andrijapanicsb , is this really what the message should say?

Copy link
Copy Markdown
Contributor

@andrijapanicsb andrijapanicsb Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we stick to the grammar wording (should (don't have to) vs. must (have to)) - then yes. The problem was that it said each network should have a label, while actually, traffic types are having labels (not networks) - that is why this change is there @DaanHoogland

See this comment (where this comes from #8625 (comment) )

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so ltgy, @andrijapanicsb ?

"message.required.tagged.physical.network": "There can only be one untagged physical network with guest traffic type.",
"message.reset.vpn.connection": "Please confirm that you want to reset VPN connection.",
"message.resize.volume.failed": "Failed to resize volume.",
Expand Down