[config] Remove config dependency#1113
Merged
Merged
Conversation
3 tasks
AlexStocks
reviewed
Jun 23, 2026
AlexStocks
reviewed
Jun 24, 2026
| array+=("rpc/multi-protocols") | ||
| array+=("rpc/triple/instance") | ||
| array+=("rpc/triple/old_triple") | ||
| # array+=("rpc/triple/old_triple") |
Contributor
There was a problem hiding this comment.
[P1] 这里把 rpc/triple/old_triple 直接从集成测试列表里注释掉了，但这个 PR 同时又改了 old_triple 的 server/client 启动路径。结果是：这部分最需要回归验证的样例，反而在本 PR 里失去了集成覆盖。除非这里能给出明确的下线/弃用说明，否则不应该通过“禁测”来带着行为改动一起合入；至少要保留覆盖，或者补上等价的新验证路径。
Member
Author
There was a problem hiding this comment.
old triple 在 new api 跑不通
反正下一步就是删除 old triple 这里干脆就不测了
AlexStocks
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.