Skip to content

feat(triple) Remove old triple implementation#3451

Open
Alanxtl wants to merge 4 commits into
apache:developfrom
Alanxtl:remove_old_triple
Open

feat(triple) Remove old triple implementation#3451
Alanxtl wants to merge 4 commits into
apache:developfrom
Alanxtl:remove_old_triple

Conversation

@Alanxtl

@Alanxtl Alanxtl commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

Fixes #3093 #2894

!! BREAKING CHANGE: no more support old-triple and old-triple fallback
!! BREAKING CHANGE: no more support the stub code generated by old version of protoc-gen-go-triple, need to regenerat stub code by latest protoc-gen-go-triple

  1. complete remove old triple
  2. update protoc-gen-go-triple to remove generated old triple
  3. update dubbogo-cli to remove old triple demonstration
  4. no more depend on https://github.com/dubbogo/triple
  5. no more depend on https://github.com/dubbogo/grpc-go

Checklist

  • I confirm the target branch is develop
  • Code has passed local testing
  • I have added tests that prove my fix is effective or that my feature works

@Alanxtl Alanxtl linked an issue Jun 25, 2026 that may be closed by this pull request
2 tasks
@Alanxtl

Alanxtl commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

ci 失败是因为 sample 还依赖 old triple
已提 pr 修复 apache/dubbo-go-samples#1116

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.96%. Comparing base (8b5bbcf) to head (0ae472f).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
protocol/triple/triple.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3451      +/-   ##
===========================================
+ Coverage    53.57%   54.96%   +1.39%     
===========================================
  Files          460      452       -8     
  Lines        35182    34693     -489     
===========================================
+ Hits         18847    19068     +221     
+ Misses       14857    14130     -727     
- Partials      1478     1495      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alanxtl

Alanxtl commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@CAICAIIs @NeverENG help review this

@Alanxtl Alanxtl linked an issue Jun 26, 2026 that may be closed by this pull request
@sonarqubecloud

Copy link
Copy Markdown

@Alanxtl Alanxtl added 4.0.0 version 4.0.0 and removed 3.3.2 version 3.3.2 labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate github.com/dubbogo/grpc-go usage [FEATURE] remove old triple protocol Delete protocol/dubbo3 and protocol/grpc grpc-go版本升级

2 participants