Add override annotations to catalog and file IO implementations#3359
Closed
adminlip wants to merge 1 commit into
Closed
Add override annotations to catalog and file IO implementations#3359adminlip wants to merge 1 commit into
adminlip wants to merge 1 commit into
Conversation
Contributor
|
Thanks a lot for this PR! It looks like this method is only supported in Python 3.12+. We're still supporting 3.10 + 3.11, so I don't think we can merge this in. |
Fokko
pushed a commit
that referenced
this pull request
May 15, 2026
Adds `@override` from `typing_extensions` to all concrete implementations of `Catalog`, `MetastoreCatalog`, `FileIO`, `InputFile`, and `OutputFile` so overridden base-class methods are explicit and can be verified by static type checkers. Uses `from typing_extensions import override` (same pattern already used for `Self` in `typedef.py`) instead of `from typing import override` which requires Python 3.12+ and would break the supported 3.10/3.11 versions. Closes #1310 # Rationale for this change `@typing.override` (PEP 698) makes it explicit which methods intentionally override a parent class method, helping static type checkers catch mistakes early. The previous attempt (#1312) and the currently open PR (#3359) both use `from typing import override` which only exists in Python 3.12+. This PR uses `typing_extensions` to support all versions from 3.10+. ## Are these changes tested? No new tests are needed — `@override` is a static analysis marker with zero runtime effect. `make lint` and `make test` (3625 passed) both pass cleanly. ## Are there any user-facing changes? No.
Contributor
|
Thanks @adminlip for working on this, but @rambleraptor is right that it requires Python 3.12 onward for the native annotation. #3360 imports it from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
typing.overrideannotations to concrete catalog and file IO implementations so overridden base-class methods are explicit and can be checked by type tooling on supported Python versions. The change covers the SQL catalog methods and the PyArrow/Fsspec file implementations referenced in the issue while keeping the diff limited to those implementation files.Closes #1310