Add @typing.override annotations to catalog and FileIO implementations#3360
Merged
Merged
Conversation
vishnuprakaz
force-pushed
the
feature/add-typing-override
branch
from
57a6ff6 to
5ccad43
Compare
rambleraptor
approved these changes
May 14, 2026
Contributor
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
This looks like a great dev UX change. Thanks for doing this!
Fokko
approved these changes
May 15, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks great @vishnuprakaz thanks for adding this 👍
Contributor
Author
|
Thanks @Fokko and @rambleraptor for the review and merge! Looking forward to contributing more to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@overridefromtyping_extensionsto all concrete implementations ofCatalog,MetastoreCatalog,FileIO,InputFile, andOutputFileso overridden base-class methods are explicit and can be verified by static type checkers.Uses
from typing_extensions import override(same pattern already used forSelfintypedef.py) instead offrom typing import overridewhich requires Python 3.12+ and would break the supported 3.10/3.11 versions.Closes #1310
Rationale for this change
@typing.override(PEP 698) makes it explicit which methods intentionally override a parent class method, helping static type checkers catch mistakes early. The previous attempt (#1312) and the currently open PR (#3359) both usefrom typing import overridewhich only exists in Python 3.12+. This PR usestyping_extensionsto support all versions from 3.10+.Are these changes tested?
No new tests are needed —
@overrideis a static analysis marker with zero runtime effect.make lintandmake test(3625 passed) both pass cleanly.Are there any user-facing changes?
No.