Skip to content

NIFI-15715 Fixed CapturingLogger to ensure it captures the stack trace for the use in unit test assertions. In addition added unit tests to TransformXML to demonstrate the use of XSLT stylesheet parameters with the use of dynamic properties.#11008

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
dan-s1:NIFI-15715
Mar 13, 2026

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Mar 13, 2026

Summary

NIFI-15715
This PR addresses the following issues:

  • Unit tests were added to exercise XSLT stylesheet parameter types in TransformXML, valid values and invalid values.
  • The bug uncovered in the CapturingLogger when writing one of these unit tests as discussed in Slack thread .
  • A logging statement in TransformXml on line 322, did not use interpolation to include the FlowFile as part of the log statement. Interpolation was added to correct that.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…e for the use in unit test assertions. In addition added unit tests to TransformXMl to demonstrate the use of XSLT stylesheet parameters with the use of dynamic properties.
@dan-s1 dan-s1 changed the title NIFI-15715 Fixed CapturingLogger to ensure it captures the stack trace for the use in unit test assertions. In addition added unit tests to TransformXMl to demonstrate the use of XSLT stylesheet parameters with the use of dynamic properties. NIFI-15715 Fixed CapturingLogger to ensure it captures the stack trace for the use in unit test assertions. In addition added unit tests to TransformXML to demonstrate the use of XSLT stylesheet parameters with the use of dynamic properties. Mar 13, 2026
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting the CapturingLogger handling of exceptions and moving these additional tests to the new PR @dan-s1, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit cfef113 into apache:main Mar 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants