Dropbear defconfig crypto deps#19498
Merged
linguini1 merged 2 commits intoJul 21, 2026
Merged
Conversation
nuttx-apps#3557 switches NETUTILS_DROPBEAR to depend on CRYPTO and CRYPTO_RANDOM_POOL instead of selecting them. sim/dropbear must enable CONFIG_CRYPTO and CONFIG_CRYPTO_RANDOM_POOL explicitly so olddefconfig and CI normalize keep dropbear and FSUTILS_PASSWD enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
… defconfig nuttx-apps#3557 switches FSUTILS_PASSWD and NETUTILS_DROPBEAR to depend on CRYPTO, CRYPTO_RANDOM_POOL, NETUTILS_CODECS and CODECS_BASE64 instead of selecting them. stm32f746g-disco/dropbear must enable these explicitly so olddefconfig/CI normalize keeps dropbear and FSUTILS_PASSWD enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
github-actions
Bot
added
Size: XS
|
Contributor
Author
|
Once this is merged, please re-run the CI at apache/nuttx-apps#3557 !! |
acassis
requested review from
cederom,
jerpelea,
linguini1,
simbit18 and
xiaoxiang781216
July 21, 2026 20:04
acassis
approved these changes
Jul 21, 2026
linguini1
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable explicit CONFIG_CRYPTO / CONFIG_CRYPTO_RANDOM_POOL in sim/dropbear so olddefconfig / CI normalize keep Dropbear and FSUTILS_PASSWD enabled after nuttx-apps #3557 . Same fix for stm32f746g-disco/dropbear, plus CONFIG_NETUTILS_CODECS / CONFIG_CODECS_BASE64, which that board was also missing.
Impact
Without these lines, CI silently drops Dropbear/passwd during normalize (red sim builds). No runtime behavior change beyond restoring configs that #3557 expects. Does not touch Dropbear or passwd Kconfig.
Testing
sim:dropbear + nuttx-apps#3557: configure, savedefconfig matches, build OK
stm32f746g-disco:dropbear: configure, savedefconfig matches, ARM build OK