feat: Compress requests using brotli algo#927
Open
mixalturek wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
==========================================
- Coverage 94.54% 94.52% -0.03%
==========================================
Files 48 48
Lines 5100 5130 +30
==========================================
+ Hits 4822 4849 +27
- Misses 278 281 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mixalturek
force-pushed
the
brotli-compression
branch
2 times, most recently
from
49bf689 to
aabd87c
Compare
- apify/apify-core#28971 added support for brotli compression to BE. - Pros: higher compression, cons: more CPU intensive. - The brotli dependencies are defined as optional, one has to explicitly enable it and choose one. If none is available, the code falls back to gzip. - JS client doesn't compress requests that are too small, this Python client compresses just everything. No change done, I only noticed and stating it.
mixalturek
force-pushed
the
brotli-compression
branch
from
aabd87c to
f26780a
Compare
This was referenced Jul 8, 2026
vdusek
requested changes
Jul 8, 2026
|
|
||
| or any other Python package manager that consumes PyPI. | ||
|
|
||
| To enable brotli request-body compression (better than gzip, especially for large payloads), install the optional extra: |
Contributor
There was a problem hiding this comment.
I'm just wondering whether this should really be the only way to configure the compression method (only via installation of extra), or whether we should introduce a new flag on the ApifyClient base class instead.
@Pijukatel WDYT?
Contributor
|
This has a significant impact. @Pijukatel, please check it as well. |
- Remove `brotlicffi`, only CPython runtime is supported. - Add a test with bytearray as an input. This would break only in `brotlicffi`, which is no longer in the dependencies. `brotli` dependency handles it correctly and doesn't throw. - Add `brotli` to dev dependencies and use it directly in tests.
mixalturek
added a commit
to apify/apify-client-js
that referenced
this pull request
Jul 8, 2026
- apify/apify-client-python#927 (comment) - The default was 11 (max). Now it uses quality 6 - roughly 2–4× faster with only a modest increase in compressed size.
Author
|
@vdusek Nearly all comments are fixed now, thanks again for your great review. One more thing: I forgot to mention that the JS client skips compression if the payload size is below 1024 B. Do we want to apply it to the Python client as well? |
mixalturek
added a commit
to apify/apify-client-js
that referenced
this pull request
Jul 8, 2026
- apify/apify-client-python#927 (comment) - The default was 11 (max). Now it uses quality 6 - roughly 2–4× faster with only a modest increase in compressed size.
mixalturek
added a commit
to apify/apify-client-js
that referenced
this pull request
Jul 8, 2026
- apify/apify-client-python#927 (comment) - The default was 11 (max). Now it uses quality 6 - roughly 2–4× faster with only a modest increase in compressed size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs