fix: add Authorization header to Histories, CreateHistory, and Delete#4
Open
RyanGWU82 wants to merge 1 commit into
Open
fix: add Authorization header to Histories, CreateHistory, and Delete#4RyanGWU82 wants to merge 1 commit into
RyanGWU82 wants to merge 1 commit into
Conversation
These three methods were making authenticated API calls without setting the Authorization header, causing the server to return 404. The fix follows the existing pattern used in Verify() and the account management methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this SDK in my own project, I found that
Histories()always returns a 404 error. The root cause is that three methods on the account history endpoints make authenticated API calls without setting theAuthorizationheader.The Things Cloud server returns HTTP 404 (not 401) for unauthenticated requests to these endpoints, so the failure gives no hint that auth is the problem.
Affected methods:
Client.Histories()— GET/own-history-keysClient.CreateHistory()— POST/own-history-keysHistory.Delete()— DELETE/own-history-keys/:idAll three now set
Authorization: Password <password>, matching the pattern already used inVerify().Tests are extended to assert the header is present on each request.