Skip to content

[codex] fix history auth and sync pagination#6

Open
pdurlej wants to merge 1 commit into
arthursoares:mainfrom
pdurlej:codex/fix-history-auth-sync-pagination
Open

[codex] fix history auth and sync pagination#6
pdurlej wants to merge 1 commit into
arthursoares:mainfrom
pdurlej:codex/fix-history-auth-sync-pagination

Conversation

@pdurlej

@pdurlej pdurlej commented May 19, 2026

Copy link
Copy Markdown

Summary

  • add the missing Authorization: Password ... header to Histories, CreateHistory, and History.Delete
  • make History.Items compute LoadedServerIndex from the requested start-index, so pagination works after a stored non-zero cursor
  • update Syncer.Sync to request the next page from LoadedServerIndex and add regression coverage

Context

This covers the auth issue already raised in #4 and the sync pagination issue raised in #5. While checking #5, I found the one-line fix still breaks incremental syncs that resume from a stored cursor greater than zero: after fetching start-index=100, it asks for start-index=1. This patch fixes that cursor accounting in Items() as well.

Validation

  • go test ./...

@pdurlej pdurlej marked this pull request as ready for review May 19, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant