chore: Add test for filtering on doubly-nested embedded resource fields#706
Merged
zachdaniel merged 1 commit intomainfrom Mar 4, 2026
Merged
chore: Add test for filtering on doubly-nested embedded resource fields#706zachdaniel merged 1 commit intomainfrom
zachdaniel merged 1 commit intomainfrom
Conversation
Adds `AshPostgres.Test.BioAddress` as a nested embedded resource within `AshPostgres.Test.Bio`, and a regression test that filters `Author` records by `bio[:address][:city]`. This exercises the `get_path` code path for doubly-nested embedded resources, which previously raised a `CaseClauseError` in `AshSql.Expr.split_at_paths/4`.
sevenseacat
changed the title
7 tasks
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AshPostgres.Test.BioAddressas a nested embedded resource withinAshPostgres.Test.Bio, and a regression test that filtersAuthorrecords bybio[:address][:city].This exercises the
get_pathcode path for doubly-nested embedded resources, which previously raised aCaseClauseErrorinAshSql.Expr.split_at_paths/4.This is a companion PR to the actual bug fix in AshSql - ash-project/ash_sql#217
Contributor checklist
Leave anything that you believe does not apply unchecked.