fix: Fix CaseClauseError when filtering/sorting on doubly-nested embedded resource fields#217
Merged
zachdaniel merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
…dded resource fields
`split_at_paths` accumulates path segments as it walks a `get_path` expression.
The `:bracket` arm only matched `{:bracket, path, nil, nil}` — the initial empty
state. After the first embedded hop the accumulator carries real type and
constraint info, so no clause matched and a `CaseClauseError` was raised.
Widening the pattern to `{:bracket, path, _, _}` allows consecutive JSONB
bracket accesses to keep accumulating into the same segment, which `do_get_path`
already handles correctly via `jsonb_extract_path_text(col, 'key1', 'key2', ...)`.
zachdaniel
approved these changes
Mar 4, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_at_pathsaccumulates path segments as it walks aget_pathexpression. The:bracketarm only matched{:bracket, path, nil, nil}— the initial empty state. After the first embedded hop the accumulator carries real type and constraint info, so no clause matched and aCaseClauseErrorwas raised.Widening the pattern to
{:bracket, path, _, _}allows consecutive JSONB bracket accesses to keep accumulating into the same segment, whichdo_get_pathalready handles correctly viajsonb_extract_path_text(col, 'key1', 'key2', ...).The tests for this are in AshPostgres, as AshSql doesn't have any of its own tests - see ash-project/ash_postgres#706
Contributor checklist
Leave anything that you believe does not apply unchecked.