fix(cli): surface API cache write failures instead of silently re-syncing#28
Merged
Conversation
…cing
Cache.WriteConfig() errors were swallowed, so a failed expiry write made
every subsequent invocation treat the spec cache as missing and re-sync
('No cached API spec, syncing...' on each call). Log the failure reason
to stderr, and include the file path in the cbor cache write error.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In diver instant-eval pods ~92% of questions hit
No cached API spec, syncing...on every surf call. One contributing factor:cacheAPI()swallowsCache.WriteConfig()errors, so when the expiry write fails the CLI silently degrades into re-syncing the spec on every invocation with no clue why.What
Cache.WriteConfig()failure to stderr with the reason (and a hint that next runs will re-sync)No behavior change on the happy path; stdout JSON untouched.
Testing
go build/go vetclean;go test ./clipasses (TestRequestRetryAfterskipped — hangs under local proxy, pre-existing).🤖 Generated with Claude Code