Skip to content

fix(cli): surface API cache write failures instead of silently re-syncing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappySean2845 merged 1 commit into from
Jun 10, 2026
Merged

fix(cli): surface API cache write failures instead of silently re-syncing #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cli/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,20 @@ func cacheAPI(name string, api *API) {
}

Cache.Set(name+".expires", time.Now().Add(24*time.Hour))
Cache.WriteConfig()
if err := Cache.WriteConfig(); err != nil {
// Without the persisted expiry, LoadCachedAPI treats the cache as
// missing and every subsequent invocation re-syncs the spec.
// Surface the reason on stderr instead of silently degrading.
LogError("Could not persist API cache expiry (next runs will re-sync): %s", err)
}

b, err := cbor.Marshal(api)
if err != nil {
LogError("Could not marshal API cache %s", err)
}
filename := filepath.Join(getCacheDir(), name+".cbor")
if err := os.WriteFile(filename, b, 0o600); err != nil {
LogError("Could not write API cache %s", err)
LogError("Could not write API cache %s (next runs will re-sync): %s", filename, err)
}
}

Expand Down
Loading