fix: change ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.10#116
Merged
adi-wan-askui merged 1 commit intomainfrom Aug 15, 2025
Conversation
…can be used like regular strings in Python 3.13
adi-wan-askui
changed the title
ModelName to a regular class so that (class) constants can be used like regular strings in Python 3.13ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.13
adi-wan-askui
changed the title
ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.13ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.10
danyalxahid-askui
approved these changes
Aug 14, 2025
Contributor
danyalxahid-askui
left a comment
danyalxahid-askui
left a comment
There was a problem hiding this comment.
lgtm.
Assuming this also solves the issue with boolean response schema for gemini models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…can be used like regular strings in Python > 3.10
"ModelName.GEMINI__2_5__FLASH"was passed as model id instead of"gemini-2.5-flash"