Skip to content

fix: change ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.10 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adi-wan-askui merged 1 commit into from
Aug 15, 2025
Merged

fix: change ModelName to a regular class so that (class) constants can be used like regular strings in Python >3.10 #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/askui/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@

_ANTHROPIC__CLAUDE__3_5__SONNET__20241022__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022.value,
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022,
system=_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20241022_BETA_FLAG],
),
)

_CLAUDE__SONNET__4__20250514__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.CLAUDE__SONNET__4__20250514.value,
model=ModelName.CLAUDE__SONNET__4__20250514,
system=_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20250124_BETA_FLAG],
thinking={"type": "enabled", "budget_tokens": 2048},
Expand Down
4 changes: 2 additions & 2 deletions src/askui/android_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,15 @@

_ANTHROPIC__CLAUDE__3_5__SONNET__20241022__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022.value,
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022,
system=_SYSTEM_PROMPT,
betas=[],
),
)

_CLAUDE__SONNET__4__20250514__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.CLAUDE__SONNET__4__20250514.value,
model=ModelName.CLAUDE__SONNET__4__20250514,
system=_SYSTEM_PROMPT,
thinking={"type": "enabled", "budget_tokens": 2048},
betas=[],
Expand Down
4 changes: 0 additions & 4 deletions src/askui/models/anthropic/messages_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ def build_system_prompt_locate(screen_width: str, screen_height: str) -> str:
"claude-3-5-sonnet-20241022"
),
ModelName.CLAUDE__SONNET__4__20250514: "claude-sonnet-4-20250514",
ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022.value: (
"claude-3-5-sonnet-20241022"
),
ModelName.CLAUDE__SONNET__4__20250514.value: "claude-sonnet-4-20250514",
}
)
)
Expand Down
6 changes: 3 additions & 3 deletions src/askui/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import abc
import re
from collections.abc import Iterator
from enum import Enum
from typing import Annotated, Callable, Type

from pydantic import BaseModel, ConfigDict, Field, RootModel
Expand All @@ -16,10 +15,11 @@
from askui.utils.image_utils import ImageSource


class ModelName(str, Enum):
class ModelName:
"""Enumeration of all available model names in AskUI.

This enum provides type-safe access to model identifiers used throughout the
This enum is not really an `enum.Enum` but rather a collection of literal strings.
It provides type-safe access to model identifiers used throughout the
library. Each model name corresponds to a specific AI model or model composition
that can be used for different tasks like acting, getting information, or locating
elements.
Expand Down
4 changes: 2 additions & 2 deletions src/askui/web_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@

_ANTHROPIC__CLAUDE__3_5__SONNET__20241022__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022.value,
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022,
system=_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20241022_BETA_FLAG],
),
)

_CLAUDE__SONNET__4__20250514__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.CLAUDE__SONNET__4__20250514.value,
model=ModelName.CLAUDE__SONNET__4__20250514,
system=_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20250124_BETA_FLAG],
thinking={"type": "enabled", "budget_tokens": 2048},
Expand Down
4 changes: 2 additions & 2 deletions src/askui/web_testing_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,15 @@

_ANTHROPIC__CLAUDE__3_5__SONNET__20241022__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022.value,
model=ModelName.ANTHROPIC__CLAUDE__3_5__SONNET__20241022,
system=_TESTING_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20241022_BETA_FLAG],
),
)

_CLAUDE__SONNET__4__20250514__ACT_SETTINGS = ActSettings(
messages=MessageSettings(
model=ModelName.CLAUDE__SONNET__4__20250514.value,
model=ModelName.CLAUDE__SONNET__4__20250514,
system=_TESTING_SYSTEM_PROMPT,
betas=[COMPUTER_USE_20250124_BETA_FLAG],
thinking={"type": "enabled", "budget_tokens": 2048},
Expand Down
4 changes: 3 additions & 1 deletion tests/e2e/agent/test_get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ def test_get_with_string_schema(
assert response in ["https://github.com/login", "github.com/login"]


@pytest.mark.parametrize("model", [ModelName.ASKUI])
@pytest.mark.parametrize(
"model", [ModelName.ASKUI, ModelName.ASKUI__GEMINI__2_5__FLASH]
)
def test_get_with_boolean_schema(
vision_agent: VisionAgent,
github_login_screenshot: PILImage.Image,
Expand Down