Skip to content

chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl#178

Merged
jbedard merged 1 commit intomainfrom
bazel-presets
Jan 22, 2026
Merged

chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl#178
jbedard merged 1 commit intomainfrom
bazel-presets

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Jan 16, 2026

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows
Copy link

aspect-workflows bot commented Jan 16, 2026

Test

All tests were cache hits

14 tests (100.0%) were fully cached saving 1s.


Test

e2e/loaders

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.


Test

e2e/loaders_jslib

All tests were cache hits

1 test (100.0%) was fully cached saving 29ms.


Test

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 81ms.


Test

e2e/smoke_rjs3

All tests were cache hits

1 test (100.0%) was fully cached saving 45ms.


Test

e2e/worker

All tests were cache hits

2 tests (100.0%) were fully cached saving 102ms.


Buildifier

@jbedard jbedard force-pushed the bazel-presets branch 4 times, most recently from ba17964 to 7932630 Compare January 16, 2026 01:21
@jbedard jbedard requested a review from alexeagle January 16, 2026 01:27
@jbedard
Copy link
Member Author

jbedard commented Jan 16, 2026

@alexeagle have you setup bazelrc-preset.bzl in a repo still testing on WORKSPACE before? Ignore the tools/ directory when run without bzlmod?

Or I can remove support for bazel test --enable_bzlmod=0 in the main repo, like we've done in rules_ts etc...

@jbedard jbedard changed the title chore: migrace aspect_bazel_lib bazelrc to bazelrc-preset.bzl chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl Jan 16, 2026
@jbedard
Copy link
Member Author

jbedard commented Jan 17, 2026

I think that might best be solved by simply removing the use of+testing WORKSPACE in the main repo: #181

@jbedard jbedard marked this pull request as ready for review January 17, 2026 23:17
@jbedard jbedard changed the base branch from main to rm-wksp-root January 19, 2026 18:00
@jbedard jbedard force-pushed the bazel-presets branch 2 times, most recently from c04da23 to b9729af Compare January 19, 2026 18:27
@@ -13,8 +7,8 @@ import %workspace%/.aspect/bazelrc/performance.bazelrc
# https://bazelbuild.slack.com/archives/C014RARENH0/p1691158021917459?thread_ts=1691156601.420349&cid=C014RARENH0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add common --config=ruleset

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think config=ruleset should remove lockfile_mode which config=ci enables? With rulesets we often want to test with multiple bazel versions which is causing issues for me in multiple repos right now, that's why I'm only updating to bazelrc-preset.bzl 1.5 and not latest...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone made a case that rulesets should check in a lockfile, I personally agree with you that it's a PITA with no value

Base automatically changed from rm-wksp-root to main January 22, 2026 02:36
@jbedard jbedard merged commit 217416b into main Jan 22, 2026
12 checks passed
@jbedard jbedard deleted the bazel-presets branch January 22, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants