chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl#178
chore: migrate aspect_bazel_lib bazelrc to bazelrc-preset.bzl#178
Conversation
|
ba17964 to
7932630
Compare
|
@alexeagle have you setup Or I can remove support for |
|
I think that might best be solved by simply removing the use of+testing WORKSPACE in the main repo: #181 |
c04da23 to
b9729af
Compare
| @@ -13,8 +7,8 @@ import %workspace%/.aspect/bazelrc/performance.bazelrc | |||
| # https://bazelbuild.slack.com/archives/C014RARENH0/p1691158021917459?thread_ts=1691156601.420349&cid=C014RARENH0 | |||
There was a problem hiding this comment.
you should add common --config=ruleset
There was a problem hiding this comment.
Do you think config=ruleset should remove lockfile_mode which config=ci enables? With rulesets we often want to test with multiple bazel versions which is causing issues for me in multiple repos right now, that's why I'm only updating to bazelrc-preset.bzl 1.5 and not latest...
There was a problem hiding this comment.
Someone made a case that rulesets should check in a lockfile, I personally agree with you that it's a PITA with no value
b9729af to
1c47ea0
Compare
1c47ea0 to
8fd9cc8
Compare


Changes are visible to end-users: no
Test plan